Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 354053002: Report all transformer load errors before exiting. (Closed)

Created:
6 years, 5 months ago by nweiz
Modified:
6 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Report all transformer load errors before exiting. Previously, pub would exit immediately after the first load error was reported. Now it will wait to see if any other transformers have errors and report those as well. R=rnystrom@google.com BUG=14552 Committed: https://code.google.com/p/dart/source/detail?r=37770

Patch Set 1 #

Total comments: 4

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -38 lines) Patch
M sdk/lib/_internal/pub/bin/pub.dart View 3 chunks +3 lines, -30 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/exceptions.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/log.dart View 2 chunks +41 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/utils.dart View 1 2 chunks +16 lines, -0 lines 0 comments Download
A + sdk/lib/_internal/pub/test/transformer/multiple_transformers_reject_their_config_test.dart View 1 3 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
6 years, 5 months ago (2014-06-26 20:11:13 UTC) #1
Bob Nystrom
https://codereview.chromium.org/354053002/diff/1/sdk/lib/_internal/pub/lib/src/utils.dart File sdk/lib/_internal/pub/lib/src/utils.dart (right): https://codereview.chromium.org/354053002/diff/1/sdk/lib/_internal/pub/lib/src/utils.dart#newcode21 sdk/lib/_internal/pub/lib/src/utils.dart:21: import 'log.dart' as log; Put this above export. https://codereview.chromium.org/354053002/diff/1/sdk/lib/_internal/pub/test/transformer/multiple_transformers_reject_their_config_test.dart ...
6 years, 5 months ago (2014-06-26 22:24:45 UTC) #2
Bob Nystrom
lgtm
6 years, 5 months ago (2014-06-26 22:24:51 UTC) #3
nweiz
https://codereview.chromium.org/354053002/diff/1/sdk/lib/_internal/pub/lib/src/utils.dart File sdk/lib/_internal/pub/lib/src/utils.dart (right): https://codereview.chromium.org/354053002/diff/1/sdk/lib/_internal/pub/lib/src/utils.dart#newcode21 sdk/lib/_internal/pub/lib/src/utils.dart:21: import 'log.dart' as log; On 2014/06/26 22:24:45, Bob Nystrom ...
6 years, 5 months ago (2014-06-26 23:01:04 UTC) #4
nweiz
6 years, 5 months ago (2014-06-26 23:02:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r37770 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698