Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart

Issue 354053002: Report all transformer load errors before exiting. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/bin/pub.dart ('k') | sdk/lib/_internal/pub/lib/src/exceptions.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart
diff --git a/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart b/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart
index 0c85fea9ed522aecca0732cf3a14149e991c3714..5956aeabacf785dc1a7623eb1d6b013db11437e4 100644
--- a/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart
+++ b/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart
@@ -246,9 +246,11 @@ class _TransformerLoader {
/// If any library hasn't yet been loaded via [load], it will be ignored.
Future<List<Set<Transformer>>> transformersForPhases(
Iterable<Set<TransformerConfig>> phases) {
- return Future.wait(phases.map((phase) =>
- Future.wait(phase.map(transformersFor)).then(unionAll)))
- // Return a growable list so that callers can add phases.
- .then((phases) => phases.toList());
+ return Future.wait(phases.map((phase) {
+ return waitAndPrintErrors(phase.map(transformersFor)).then(unionAll);
+ })).then((phases) {
+ // Return a growable list so that callers can add phases.
+ return phases.toList();
+ });
}
}
« no previous file with comments | « sdk/lib/_internal/pub/bin/pub.dart ('k') | sdk/lib/_internal/pub/lib/src/exceptions.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698