Issue 351703002: Class view: list all/sample instances on request.

Issue 351703002: Class view: list all/sample instances on request. (Closed)

Created:
6 years, 6 months ago by koda

Modified:
6 years, 6 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Class view: list all/sample instances on request. The returned list can be filtered, etc., using its eval box. Change VM code to only get reachable instances, using ObjectGraph. BUG=dart: R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37661

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1116 lines, -890 lines)			Patch
M	runtime/bin/vmservice/client/deployed/web/index.html	View	1 2 3 4 5	1 chunk	+22 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View		149 chunks	+493 lines, -433 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html	View	1 2 3 4 5	1 chunk	+22 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js	View		149 chunks	+493 lines, -433 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/class_view.html	View	1 2 3 4 5	1 chunk	+26 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/class_view.dart	View	1 2 3 4 5	3 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/class_view.html	View	1 2 3 4 5	1 chunk	+26 lines, -3 lines	0 comments	Download
M	runtime/vm/service.cc	View	1 2 3 4 5	4 chunks	+19 lines, -10 lines	0 comments	Download
M	runtime/vm/service_test.cc	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Cutch

Does this handle refreshing the page? https://codereview.chromium.org/351703002/diff/40001/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/351703002/diff/40001/runtime/vm/service.cc#newcode1200 runtime/vm/service.cc:1200: jsobj.AddProperty("total_count", count); use ...

6 years, 6 months ago (2014-06-24 15:56:39 UTC) #2

koda

Refresh now restores the [calculate]/[find] links correctly. https://codereview.chromium.org/351703002/diff/40001/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/351703002/diff/40001/runtime/vm/service.cc#newcode1200 runtime/vm/service.cc:1200: jsobj.AddProperty("total_count", count); ...

6 years, 6 months ago (2014-06-24 16:05:00 UTC) #3

koda

6 years, 6 months ago (2014-06-24 16:14:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #6 manually as r37661 (presubmit successful).

Expand Messages | Collapse Messages