Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/class_view.dart

Issue 351703002: Class view: list all/sample instances on request. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/class_view.dart
===================================================================
--- runtime/bin/vmservice/client/lib/src/elements/class_view.dart (revision 37660)
+++ runtime/bin/vmservice/client/lib/src/elements/class_view.dart (working copy)
@@ -12,6 +12,7 @@
@CustomTag('class-view')
class ClassViewElement extends ObservatoryElement {
@published Class cls;
+ @observable ServiceMap instances;
@observable int retainedBytes;
ClassViewElement.created() : super.created();
@@ -19,6 +20,13 @@
return cls.get("eval?expr=${Uri.encodeComponent(text)}");
}
+ Future<ServiceObject> reachable(var limit) {
+ return cls.get("instances?limit=$limit")
+ .then((ServiceMap obj) {
+ instances = obj;
+ });
+ }
+
// TODO(koda): Add no-arg "calculate-link" instead of reusing "eval-link".
Future<ServiceObject> retainedSize(var dummy) {
return cls.get("retained")
@@ -28,6 +36,8 @@
}
void refresh(var done) {
+ instances = null;
+ retainedBytes = null;
cls.reload().whenComplete(done);
}
}

Powered by Google App Engine
This is Rietveld 408576698