Issue 351283003: Move Tokenfactory, AstFactory and ElementFactory from tests to the testing/ Folder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 351283003: Move Tokenfactory, AstFactory and ElementFactory from tests to the testing/ Folder. (Closed)

Created:
6 years, 6 months ago by scheglov

Modified:
6 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move Tokenfactory, AstFactory and ElementFactory from tests to the testing/ Folder. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37748

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1400 lines, -1068 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/ClassElementImpl.java	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/FieldElementImpl.java	View	3 chunks	+6 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/LibraryElementImpl.java	View	2 chunks	+15 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/LocalVariableElementImpl.java	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/ParameterElementImpl.java	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/PrefixElementImpl.java	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/PropertyAccessorElementImpl.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/PropertyInducingElementImpl.java	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/TopLevelVariableElementImpl.java	View	3 chunks	+6 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/TypeParameterElementImpl.java	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/source/NonExistingSource.java	View	3 chunks	+15 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/element/ElementFactory.java	View	18 chunks	+41 lines, -38 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java	View	11 chunks	+107 lines, -19 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/element.dart	View	22 chunks	+95 lines, -38 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/error.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	21 chunks	+29 lines, -25 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/source.dart	View	1 chunk	+53 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/source_io.dart	View	1 chunk	+0 lines, -41 lines	0 comments	Download
A	pkg/analyzer/lib/src/generated/testing/ast_factory.dart	View	1 chunk	+428 lines, -0 lines	0 comments	Download
A	pkg/analyzer/lib/src/generated/testing/element_factory.dart	View	1 chunk	+385 lines, -0 lines	0 comments	Download
A	pkg/analyzer/lib/src/generated/testing/token_factory.dart	View	1 chunk	+23 lines, -0 lines	0 comments	Download
M	pkg/analyzer/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/ast_test.dart	View	2 chunks	+2 lines, -417 lines	0 comments	Download
M	pkg/analyzer/test/generated/element_test.dart	View	20 chunks	+38 lines, -402 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_test.dart	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	43 chunks	+84 lines, -56 lines	0 comments	Download
M	pkg/analyzer/test/generated/scanner_test.dart	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

6 years, 6 months ago (2014-06-26 17:30:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r37748 (presubmit successful).

Expand Messages | Collapse Messages