editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java - Issue 351283003: Move Tokenfactory, AstFactory and ElementFactory from tests to the testing/ Folder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java

Issue 351283003: Move Tokenfactory, AstFactory and ElementFactory from tests to the testing/ Folder. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/ClassElementImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java

index 25e9e3ff98a75460050822d51fbbf834faac7ef5..d1fd839174ef6622e8455f1a90d1ed8c145aaccb 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java

@@ -457,7 +457,7 @@ public class ElementBuilder extends RecursiveAstVisitor<Void> {

String propertyName = propertyNameNode.getName();

TopLevelVariableElementImpl variable = (TopLevelVariableElementImpl) currentHolder.getTopLevelVariable(propertyName);

if (variable == null) {

- variable = new TopLevelVariableElementImpl(node.getName().getName());

+ variable = new TopLevelVariableElementImpl(node.getName().getName(), -1);

variable.setFinal(true);

variable.setSynthetic(true);

@@ -628,7 +628,7 @@ public class ElementBuilder extends RecursiveAstVisitor<Void> {

String propertyName = propertyNameNode.getName();

FieldElementImpl field = (FieldElementImpl) currentHolder.getField(propertyName);

if (field == null) {

- field = new FieldElementImpl(node.getName().getName());

+ field = new FieldElementImpl(node.getName().getName(), -1);

field.setFinal(true);

field.setStatic(isStatic);

field.setSynthetic(true);