Issue 35093002: Fix bug with load elimination in checked mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 35093002: Fix bug with load elimination in checked mode. (Closed)

Created:
7 years, 2 months ago by Florian Schneider

Modified:
7 years, 2 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug with load elimination in checked mode. Definitions that are redefined through AssertAssignable must be unwrapped to number loads/stores correctly for them. Fix test expectations for tests that are passing now that the corresponding co19 test was changed. BUG=https://code.google.com/p/dart/issues/detail?id=13543 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=29001

Patch Set 1 #

Patch Set 2 : updated status file, fixed another issue an issue with alias analysis #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -14 lines)			Patch
M	pkg/pkg.status	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	2 chunks	+10 lines, -4 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

I identified another issue with alias analysis. +cc John: I updated the test expectations for ...

7 years, 2 months ago (2013-10-22 15:40:56 UTC) #3

Florian Schneider

7 years, 2 months ago (2013-10-22 16:03:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r29001 (presubmit successful).

Expand Messages | Collapse Messages