Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 35093002: Fix bug with load elimination in checked mode. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: updated status file, fixed another issue an issue with alias analysis Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/pkg.status ('k') | tests/co19/co19-runtime.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 28998)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -4320,8 +4320,12 @@
private:
static Definition* OriginalDefinition(Definition* defn) {
- while (defn->IsRedefinition()) {
- defn = defn->AsRedefinition()->value()->definition();
+ while (defn->IsRedefinition() || defn->IsAssertAssignable()) {
+ if (defn->IsRedefinition()) {
+ defn = defn->AsRedefinition()->value()->definition();
+ } else {
+ defn = defn->AsAssertAssignable()->value()->definition();
+ }
}
return defn;
}
@@ -4539,8 +4543,10 @@
if (instr->IsPushArgument() ||
(instr->IsStoreVMField() && (use->use_index() != 1)) ||
(instr->IsStoreInstanceField() && (use->use_index() != 0)) ||
- (instr->IsStoreStaticField()) ||
- (instr->IsPhi())) {
+ instr->IsStoreStaticField() ||
+ instr->IsPhi() ||
+ instr->IsAssertAssignable() ||
+ instr->IsRedefinition()) {
escapes = true;
break;
}
« no previous file with comments | « pkg/pkg.status ('k') | tests/co19/co19-runtime.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698