Issue 349683003: Improve running in iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 349683003: Improve running in iframes. (Closed)

Created:
6 years, 6 months ago by ahe

Modified:
6 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, Johnni Winther, lukechurch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+175 lines, -57 lines)			Patch
M	dart/site/try/src/compilation.dart	View	1	3 chunks	+29 lines, -29 lines	0 comments	Download
A	dart/site/try/src/iframe_error_handler.dart	View		1 chunk	+96 lines, -0 lines	0 comments	Download
M	dart/site/try/src/interaction_manager.dart	View	1	6 chunks	+25 lines, -3 lines	0 comments	Download
M	dart/site/try/src/run.dart	View		1 chunk	+25 lines, -25 lines	0 comments	Download

Total messages: 4 (0 generated)

ahe

FYI: Lack of testing tracked with https://code.google.com/p/dart/issues/detail?id=19614.

6 years, 6 months ago (2014-06-23 15:25:17 UTC) #3

ahe

6 years, 6 months ago (2014-06-23 15:26:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r37603 (presubmit successful).