Issue 34963002: Fix another closure/type variable error by using analyzeTypeVariables.

Issue 34963002: Fix another closure/type variable error by using analyzeTypeVariables. (Closed)

Created:
7 years, 2 months ago by ngeoffray

Modified:
7 years, 2 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix another closure/type variable error by using analyzeTypeVariables. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=29061

Patch Set 2 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -6 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/closure.dart	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		2 chunks	+4 lines, -2 lines	0 comments	Download
A	tests/language/issue14014_2_test.dart	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
A	tests/language/issue14014_3_test.dart	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/34963002/diff/100001/tests/language/issue14014_2_test.dart File tests/language/issue14014_2_test.dart (right): https://codereview.chromium.org/34963002/diff/100001/tests/language/issue14014_2_test.dart#newcode3 tests/language/issue14014_2_test.dart:3: // BSD-style license that can be found in ...

7 years, 2 months ago (2013-10-23 06:11:32 UTC) #2

ngeoffray

Thanks Johnni. https://codereview.chromium.org/34963002/diff/100001/tests/language/issue14014_2_test.dart File tests/language/issue14014_2_test.dart (right): https://codereview.chromium.org/34963002/diff/100001/tests/language/issue14014_2_test.dart#newcode3 tests/language/issue14014_2_test.dart:3: // BSD-style license that can be found ...

7 years, 2 months ago (2013-10-23 06:43:41 UTC) #3

ngeoffray

7 years, 2 months ago (2013-10-23 06:45:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r29061 (presubmit successful).

Expand Messages | Collapse Messages