Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: sdk/lib/_internal/compiler/implementation/closure.dart

Issue 34963002: Fix another closure/type variable error by using analyzeTypeVariables. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/closure.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/closure.dart (revision 28989)
+++ sdk/lib/_internal/compiler/implementation/closure.dart (working copy)
@@ -555,11 +555,10 @@
Element element = elements[node];
if (Elements.isLocal(element)) {
mutatedVariables.add(element);
+ if (compiler.enableTypeAssertions) {
+ analyzeTypeVariables(element.computeType(compiler));
+ }
}
- if (Elements.isLocal(element) &&
- element.computeType(compiler).containsTypeVariables) {
- registerNeedsThis();
- }
super.visitSendSet(node);
}
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698