Issue 349573004: close channel and exit analysis server on editor shutdown

Issue 349573004: close channel and exit analysis server on editor shutdown (Closed)

Created:
6 years, 6 months ago by danrubel

Modified:
6 years, 6 months ago

Reviewers:
jwren, scheglov

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

close channel and exit analysis server on editor shutdown BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=37597

Patch Set 1 #

Patch Set 2 : merge #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -7 lines)			Patch
A +	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/BasicConsumer.java	View	1 chunk	+7 lines, -4 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/ByteRequestSink.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java	View	3 chunks	+10 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RequestSink.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/ByteRequestSinkTest.java	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java	View	1 chunk	+9 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/TestRequestSink.java	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/driver.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

danrubel

Committed patchset #2 manually as r37597 (presubmit successful).

6 years, 6 months ago (2014-06-23 12:49:55 UTC) #3

jwren

On 2014/06/23 12:49:55, danrubel wrote: > Committed patchset #2 manually as r37597 (presubmit successful).

6 years, 6 months ago (2014-06-23 17:20:31 UTC) #4

jwren

6 years, 6 months ago (2014-06-23 17:20:40 UTC) #5

Message was sent while issue was closed.

On 2014/06/23 17:20:31, jwren wrote:
> On 2014/06/23 12:49:55, danrubel wrote:
> > Committed patchset #2 manually as r37597 (presubmit successful).

LGTM

Expand Messages | Collapse Messages