editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java - Issue 349573004: close channel and exit analysis server on editor shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java

Issue 349573004: close channel and exit analysis server on editor shutdown (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/ByteRequestSinkTest.java ('k') | editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/TestRequestSink.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java

diff --git a/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java b/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java

index d6c2edb392290246fc4e7f17d93315ca273a6421..791df208d1403d4b44777af3e89c305f3decae75 100644

--- a/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java

+++ b/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java

@@ -843,13 +843,20 @@ public class RemoteAnalysisServerImplTest extends AbstractRemoteServerTest {

public void test_server_shutdown() throws Exception {

server.shutdown();

- List<JsonObject> requests = requestSink.getRequests();

JsonElement expected = parseJson(//

"{",

" 'id': '0',",

" 'method': 'server.shutdown'",

"}");

- assertTrue(requests.contains(expected));

+ assertTrue(requestSink.getRequests().contains(expected));

+ assertFalse(requestSink.isClosed());

+ putResponse(//

+ "{",

+ " 'id': '0'",

+ "}");

+ responseStream.waitForEmpty();

+ server.test_waitForWorkerComplete();

+ assertTrue(requestSink.isClosed());

}

/**