Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 348473004: Fix tools/full-coverage.dart script and add standalone test (Closed)

Created:
6 years, 6 months ago by Michael Lippautz (Google)
Modified:
6 years, 6 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Fix tools/full-coverage.dart script and add standalone test. Test checks coverage data of a given script and differentiates between: * no coverage data * no hits (IC=0) * some hits (IC>0) BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37571

Patch Set 1 : #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -3 lines) Patch
A tests/standalone/full_coverage_test.dart View 1 2 1 chunk +233 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M tools/full-coverage.dart View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Lippautz (Google)
unittest and path work and make the life easier here. I will rewrite if needed.
6 years, 6 months ago (2014-06-19 01:31:05 UTC) #1
Ivan Posva
https://codereview.chromium.org/348473004/diff/80001/tests/standalone/full_coverage_test.dart File tests/standalone/full_coverage_test.dart (right): https://codereview.chromium.org/348473004/diff/80001/tests/standalone/full_coverage_test.dart#newcode55 tests/standalone/full_coverage_test.dart:55: ]; Are you planning to add more tests? Such ...
6 years, 6 months ago (2014-06-20 18:27:16 UTC) #2
Michael Lippautz (Google)
https://codereview.chromium.org/348473004/diff/80001/tests/standalone/full_coverage_test.dart File tests/standalone/full_coverage_test.dart (right): https://codereview.chromium.org/348473004/diff/80001/tests/standalone/full_coverage_test.dart#newcode55 tests/standalone/full_coverage_test.dart:55: ]; On 2014/06/20 18:27:16, Ivan Posva wrote: > Are ...
6 years, 6 months ago (2014-06-20 19:31:45 UTC) #3
Ivan Posva
LGTM -ip
6 years, 6 months ago (2014-06-20 23:15:50 UTC) #4
Michael Lippautz (Google)
6 years, 6 months ago (2014-06-20 23:25:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r37571 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698