Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: tools/full-coverage.dart

Issue 348473004: Fix tools/full-coverage.dart script and add standalone test (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/standalone.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/full-coverage.dart
diff --git a/tools/full-coverage.dart b/tools/full-coverage.dart
index bafc0d1b5aa7b02adfe96770a863e4fbca9335ee..29635743f0e8b026faf88713aa895e139e147373 100644
--- a/tools/full-coverage.dart
+++ b/tools/full-coverage.dart
@@ -17,8 +17,8 @@ class Environment {
var input;
var output;
int workers;
- bool prettyPrint;
- bool lcov;
+ bool prettyPrint = false;
+ bool lcov = false;
bool expectMarkers;
bool verbose;
}
@@ -405,7 +405,8 @@ parseArgs(List<String> arguments) {
parser.addOption("sdk-root", abbr: "s",
help: "path to the SDK root");
parser.addOption("package-root", abbr: "p",
- help: "path to the package root");
+ help: "override path to the package root "
+ "(default: inherited from dart)");
parser.addOption("in", abbr: "i",
help: "input(s): may be file or directory");
parser.addOption("out", abbr: "o",
@@ -465,6 +466,8 @@ parseArgs(List<String> arguments) {
if (!FileSystemEntity.isDirectorySync(env.pkgRoot)) {
fail("Provided package root '${args["package-root"]}' is not directory.");
}
+ } else {
+ env.pkgRoot = Platform.packageRoot;
}
if (args["in"] == null) {
« no previous file with comments | « tests/standalone/standalone.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698