Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 34613005: Revert "Converting Polymer and TemplateElement to use deprecated Node.document" (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Converting Polymer and TemplateElement to use deprecated Node.document" Now that DRT is updated and we're running dart2js tests properly, all should be good. BUG=14197 R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=29018

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M pkg/mdv/lib/src/input_bindings.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/mdv/lib/src/template_iterator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/src/instance.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLTemplateElement.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 2 months ago (2013-10-22 17:45:53 UTC) #1
Jennifer Messerly
lgtm
7 years, 2 months ago (2013-10-22 18:23:25 UTC) #2
blois
7 years, 2 months ago (2013-10-22 18:28:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29018 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698