pkg/mdv/lib/src/template_iterator.dart - Issue 34613005: Revert "Converting Polymer and TemplateElement to use deprecated Node.document"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/mdv/lib/src/template_iterator.dart

Issue 34613005: Revert "Converting Polymer and TemplateElement to use deprecated Node.document" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/mdv/lib/src/template_iterator.dart

diff --git a/pkg/mdv/lib/src/template_iterator.dart b/pkg/mdv/lib/src/template_iterator.dart

index 84581657b87902afc5084e1aa70de93e8540357e..ce564ad0dc4c8727fae51503fb89ae0e4b8ae962 100644

--- a/pkg/mdv/lib/src/template_iterator.dart

+++ b/pkg/mdv/lib/src/template_iterator.dart

@@ -336,7 +336,7 @@ class _TemplateIterator {

var template = _templateElement;

var delegate = template.bindingDelegate;

- if (template.parentNode == null || template.document.window == null) {

+ if (template.parentNode == null || template.ownerDocument.window == null) {

close();

// TODO(jmesserly): MDV calls templateIteratorTable.delete(this) here,

// but I think that's a no-op because only nodes are used as keys.

« no previous file with comments | « pkg/mdv/lib/src/input_bindings.dart ('k') | pkg/polymer/lib/src/instance.dart » ('j') | no next file with comments »