Send allocation stats with each class and show in class view.

Send allocation stats with each class and show in class view.

For each class, if there are any allocations, shows current number of instances, shallow size, and the already existing link for retained size.

Also refactor code in ClassTable to reduce duplication.

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37566

[Cutch, 2014-06-20 18:10:49]

https://codereview.chromium.org/345543003/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/elements/class_view.html (right):

https://codereview.chromium.org/345543003/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/class_view.html:99: <div
class="memberName">shallow size</div>
shallow size (of all instances)?

https://codereview.chromium.org/345543003/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/class_view.html:101: {{
cls.newSpace.current.bytes + cls.oldSpace.current.bytes }}
I think this might double count. I'm not sure the correct solution.

https://codereview.chromium.org/345543003/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/class_view.html:105: <div
class="memberName">retained size</div>
(of all instances)?

https://codereview.chromium.org/345543003/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/service/object.dart (right):

https://codereview.chromium.org/345543003/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/object.dart:1047: @reflectable
final Allocations newSpace = new Allocations();
@reflectable should no longer be needed with polymer >= 0.10.x (we are on
0.11.x)

https://codereview.chromium.org/345543003/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/object.dart:1113: var
allocation_stats = map['allocation_stats'];
New service fields should use dartCamelCase.

https://codereview.chromium.org/345543003/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/345543003/diff/20001/runtime/vm/object.cc#new...
runtime/vm/object.cc:4070: JSONObject allocation_stats(&jsobj,
"allocation_stats");
new service fields use dartCamelCase

[koda, 2014-06-20 18:37:04]

PTAL

https://codereview.chromium.org/345543003/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/elements/class_view.html (right):

https://codereview.chromium.org/345543003/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/class_view.html:99: <div
class="memberName">shallow size</div>
On 2014/06/20 18:10:49, Cutch wrote:
> shallow size (of all instances)?

I made a "current instances" section instead. See attached screenshot.

https://codereview.chromium.org/345543003/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/class_view.html:101: {{
cls.newSpace.current.bytes + cls.oldSpace.current.bytes }}
On 2014/06/20 18:10:49, Cutch wrote:
> I think this might double count. I'm not sure the correct solution.

I think that's true, and that the correct solution is for us to track promotions
in the allocation stats. In any case, this is not the place to fix it, i.e.,
this expression *should* give a meaningful number.

https://codereview.chromium.org/345543003/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/class_view.html:105: <div
class="memberName">retained size</div>
On 2014/06/20 18:10:49, Cutch wrote:
> (of all instances)?

See above.

https://codereview.chromium.org/345543003/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/service/object.dart (right):

https://codereview.chromium.org/345543003/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/object.dart:1047: @reflectable
final Allocations newSpace = new Allocations();
On 2014/06/20 18:10:49, Cutch wrote:
> @reflectable should no longer be needed with polymer >= 0.10.x (we are on
> 0.11.x)

Done.

https://codereview.chromium.org/345543003/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/object.dart:1113: var
allocation_stats = map['allocation_stats'];
On 2014/06/20 18:10:49, Cutch wrote:
> New service fields should use dartCamelCase.

Done.

https://codereview.chromium.org/345543003/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/345543003/diff/20001/runtime/vm/object.cc#new...
runtime/vm/object.cc:4070: JSONObject allocation_stats(&jsobj,
"allocation_stats");
On 2014/06/20 18:10:49, Cutch wrote:
> new service fields use dartCamelCase

Done.

[Cutch, 2014-06-20 19:27:22]

lgtm

[koda, 2014-06-20 20:17:59]

Committed patchset #3 manually as r37566 (presubmit successful).