Issue 345113002: Fix Observatory code coverage

Issue 345113002: Fix Observatory code coverage (Closed)

Created:
6 years, 6 months ago by Cutch

Modified:
6 years, 6 months ago

Reviewers:
koda

CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix Observatory code coverage BUG= R=koda@google.com Committed: https://code.google.com/p/dart/source/detail?r=37555

Patch Set 3 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1929 lines, -1964 lines)			Patch
M	runtime/bin/vmservice/client/deployed/web/index.html	View	1 2	4 chunks	+13 lines, -29 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View	1 2	317 chunks	+895 lines, -886 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html	View	1 2	4 chunks	+13 lines, -29 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js	View	1 2	317 chunks	+895 lines, -886 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_summary.html	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_inset.html	View	1 2	1 chunk	+10 lines, -23 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_view.html	View	1 2	1 chunk	+1 line, -6 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/app/application.dart	View		2 chunks	+4 lines, -7 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/app/location_manager.dart	View		1 chunk	+10 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/script_inset.dart	View	1	1 chunk	+40 lines, -39 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/script_inset.html	View		1 chunk	+10 lines, -23 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/script_view.dart	View		2 chunks	+1 line, -11 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/script_view.html	View		1 chunk	+1 line, -6 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/service/object.dart	View		4 chunks	+32 lines, -18 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

koda

Please provide some more context in the CL description: what was broken? https://codereview.chromium.org/345113002/diff/1/runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html File runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html ...

6 years, 6 months ago (2014-06-20 15:40:30 UTC) #2

Cutch

https://codereview.chromium.org/345113002/diff/1/runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html File runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html (right): https://codereview.chromium.org/345113002/diff/1/runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html#newcode178 runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html:178: --> On 2014/06/20 15:40:29, koda wrote: > Is this ...

6 years, 6 months ago (2014-06-20 15:41:45 UTC) #3

Cutch

6 years, 6 months ago (2014-06-20 16:06:41 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r37555 (presubmit successful).

Expand Messages | Collapse Messages