Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2275)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/script_view.dart

Issue 345113002: Fix Observatory code coverage (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/script_view.dart
diff --git a/runtime/bin/vmservice/client/lib/src/elements/script_view.dart b/runtime/bin/vmservice/client/lib/src/elements/script_view.dart
index e3907ca799a868ae13b37b141eae271e5da5971f..64f8231cd9001c8c8d08b72f707b5053b3419e60 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/script_view.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/script_view.dart
@@ -13,7 +13,6 @@ import 'package:polymer/polymer.dart';
@CustomTag('script-view')
class ScriptViewElement extends ObservatoryElement {
@published Script script;
- @published bool showCoverage = false;
ScriptViewElement.created() : super.created();
@@ -26,20 +25,11 @@ class ScriptViewElement extends ObservatoryElement {
script.load();
}
- showCoverageChanged(oldValue) {
- ScriptInsetElement sie = shadowRoot.querySelector('#scriptInset');
- sie.coverage = showCoverage;
- }
-
void refresh(var done) {
script.reload().whenComplete(done);
}
void refreshCoverage(var done) {
- script.isolate.refreshCoverage().then((_) {
- ScriptInsetElement sie = shadowRoot.querySelector('#scriptInset');
- showCoverage = true;
- sie.coverage = showCoverage;
- }).whenComplete(done);
+ script.isolate.refreshCoverage()..whenComplete(done);
}
}

Powered by Google App Engine
This is Rietveld 408576698