Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 345063005: Fix operator== and hashCode for File and Folder objects. (Closed)

Created:
6 years, 5 months ago by Paul Berry
Modified:
6 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix operator== and hashCode for File and Folder objects. This is necessary in order for File and Folder objects to be safely stored in HashSets and HashMaps. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=37926

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -6 lines) Patch
M pkg/analysis_server/lib/src/resource.dart View 2 chunks +13 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/physical_resource_provider_test.dart View 2 chunks +19 lines, -1 line 0 comments Download
M pkg/analysis_server/test/resource_test.dart View 3 chunks +25 lines, -3 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Paul Berry
6 years, 5 months ago (2014-07-01 22:33:18 UTC) #1
scheglov
LGTM https://codereview.chromium.org/345063005/diff/1/pkg/analysis_server/test/resource_test.dart File pkg/analysis_server/test/resource_test.dart (right): https://codereview.chromium.org/345063005/diff/1/pkg/analysis_server/test/resource_test.dart#newcode298 pkg/analysis_server/test/resource_test.dart:298: expect(folder == folder2, isTrue); Any test for a ...
6 years, 5 months ago (2014-07-02 00:32:56 UTC) #2
Paul Berry
https://codereview.chromium.org/345063005/diff/1/pkg/analysis_server/test/resource_test.dart File pkg/analysis_server/test/resource_test.dart (right): https://codereview.chromium.org/345063005/diff/1/pkg/analysis_server/test/resource_test.dart#newcode298 pkg/analysis_server/test/resource_test.dart:298: expect(folder == folder2, isTrue); On 2014/07/02 00:32:56, scheglov wrote: ...
6 years, 5 months ago (2014-07-02 00:37:15 UTC) #3
Paul Berry
6 years, 5 months ago (2014-07-02 00:46:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r37926 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698