Fix operator== and hashCode for File and Folder objects.

pkg/analysis_server/test/resource_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.resource;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/resource.dart';
 import 'package:analyzer/src/generated/engine.dart' show TimestampedData;
@@ skipping 205 matching lines @@
           File fileA = provider.getResource('/fileA.txt');
           File fileB = provider.getResource('/fileB.txt');
           expect(fileA == new Object(), isFalse);
           expect(fileA == fileB, isFalse);
         });
 
         test('true', () {
           File file = provider.getResource('/file.txt');
           expect(file == file, isTrue);
         });
+
+        test('before and after creation', () {
+          String path = '/file.txt';
+          File file1 = provider.getResource(path);
+          provider.newFile(path, 'contents');
+          File file2 = provider.getResource(path);
+          expect(file1 == file2, isTrue);
+        });
       });
 
       group('exists', () {
         test('false', () {
           File file = provider.getResource('/file.txt');
           expect(file, isNotNull);
           expect(file.exists, isFalse);
         });
 
         test('true', () {
           provider.newFile('/foo/file.txt', 'qwerty');
           File file = provider.getResource('/foo/file.txt');
           expect(file, isNotNull);
           expect(file.exists, isTrue);
         });
       });
 
       test('fullName', () {
         File file = provider.getResource('/foo/bar/file.txt');
         expect(file.path, '/foo/bar/file.txt');
       });
 
       test('hashCode', () {
-        File file = provider.getResource('/foo/bar/file.txt');
-        file.hashCode;
+        String path = '/foo/bar/file.txt';
+        File file1 = provider.getResource(path);
+        provider.newFile(path, 'contents');
+        File file2 = provider.getResource(path);
+        expect(file1.hashCode, equals(file2.hashCode));
       });
 
       test('shortName', () {
         File file = provider.getResource('/foo/bar/file.txt');
         expect(file.shortName, 'file.txt');
       });
 
       test('toString', () {
         File file = provider.getResource('/foo/bar/file.txt');
         expect(file.toString(), '/foo/bar/file.txt');
       });
 
       test('parent', () {
         provider.newFile('/foo/bar/file.txt', 'content');
         File file = provider.getResource('/foo/bar/file.txt');
         Resource parent = file.parent;
         expect(parent, new isInstanceOf<Folder>());
         expect(parent.path, equals('/foo/bar'));
       });
     });
 
     group('Folder', () {
       Folder folder;
+      const String path = '/foo/bar';
 
       setUp(() {
-        folder = provider.newFolder('/foo/bar');
+        folder = provider.newFolder(path);
+      });
+
+      test('hashCode', () {
+        Folder folder2 = provider.getResource(path);
+        expect(folder.hashCode, equals(folder2.hashCode));
+      });
+
+      test('equality', () {
+        Folder folder2 = provider.getResource(path);
+        expect(folder == folder2, isTrue);

[scheglov, 2014/07/02 00:32:56]

Any test for a case when == returns false for memory/physical resources?

[Paul Berry, 2014/07/02 00:37:15]

Good point.  I'll add those.

       });
 
       group('getChild', () {
         test('does not exist', () {
           File file = folder.getChild('file.txt');
           expect(file, isNotNull);
           expect(file.exists, isFalse);
         });
 
         test('file', () {
@@ skipping 208 matching lines @@
       expect(source, isNull);
     });
 
     test('not a file URI', () {
       var uri = new Uri(scheme: 'https', path: '127.0.0.1/test.dart');
       Source source = resolver.resolveAbsolute(uri);
       expect(source, isNull);
     });
   });
 }