Issue 34223002: Throw FormatException when Int32/Int64.parseRadix() encounters bad digit

Issue 34223002: Throw FormatException when Int32/Int64.parseRadix() encounters bad digit (Closed)

Created:
7 years, 2 months ago by Chris Bracken

Modified:
7 years, 2 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Throw FormatException when Int32/Int64.parseRadix() encounters bad digit BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=29109

Patch Set 1 : Throw FormatException when Int32/Int64.parseRadix() encounters bad digit #

Total comments: 2

Patch Set 2 : Formatting fix #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -2 lines)			Patch
M	pkg/fixnum/lib/src/int32.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/fixnum/lib/src/int64.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/fixnum/test/int_32_test.dart	View		1 chunk	+27 lines, -0 lines	0 comments	Download
M	pkg/fixnum/test/int_64_test.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sra1

lgtm https://codereview.chromium.org/34223002/diff/150001/pkg/fixnum/test/int_64_test.dart File pkg/fixnum/test/int_64_test.dart (right): https://codereview.chromium.org/34223002/diff/150001/pkg/fixnum/test/int_64_test.dart#newcode637 pkg/fixnum/test/int_64_test.dart:637: test("min, max values", () { expect(new Int64(1) << ...

7 years, 2 months ago (2013-10-23 04:09:10 UTC) #4

Chris Bracken

Committed patchset #2 manually as r29109 (presubmit successful).

7 years, 2 months ago (2013-10-23 19:08:39 UTC) #5

Chris Bracken

7 years, 2 months ago (2013-10-23 23:34:12 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/34223002/diff/150001/pkg/fixnum/test/int_64_t...
File pkg/fixnum/test/int_64_test.dart (right):

https://codereview.chromium.org/34223002/diff/150001/pkg/fixnum/test/int_64_t...
pkg/fixnum/test/int_64_test.dart:637: test("min, max values", () { expect(new
Int64(1) << 63, Int64.MIN_VALUE);
On 2013/10/23 04:09:11, sra1 wrote:
> Put the first statement of the block back on its own line.

Done.

Expand Messages | Collapse Messages