Throw FormatException when Int32/Int64.parseRadix() encounters bad digit

pkg/fixnum/test/int_64_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library int64test;
 import 'package:fixnum/fixnum.dart';
 import 'package:unittest/unittest.dart';
 
 void main() {
   group("is-tests", () {
@@ skipping 616 matching lines @@
         return new Int64(1);
       } else {
         return n * _factorial(n - new Int64(1));
       }
     }
     Int64 fact18 = _factorial(new Int64(18));
     Int64 fact17 = _factorial(new Int64(17));
     expect(fact18 ~/ fact17, new Int64(18));
   });
 
-  test("min, max values", () {
-    expect(new Int64(1) << 63, Int64.MIN_VALUE);
+  test("min, max values", () { expect(new Int64(1) << 63, Int64.MIN_VALUE);

[sra1, 2013/10/23 04:09:11]

Put the first statement of the block back on its own line.

[Chris Bracken, 2013/10/23 23:34:12]

Done.

     expect(-(Int64.MIN_VALUE + new Int64(1)), Int64.MAX_VALUE);
   });
 
   group("parse", () {
     test("parseRadix10", () {
       checkInt(int x) {
         expect(Int64.parseRadix('$x', 10), new Int64(x));
       }
       checkInt(0);
       checkInt(1);
       checkInt(-1);
       checkInt(1000);
       checkInt(12345678);
       checkInt(-12345678);
       checkInt(2147483647);
       checkInt(2147483648);
       checkInt(-2147483647);
       checkInt(-2147483648);
       checkInt(4294967295);
       checkInt(4294967296);
       checkInt(-4294967295);
       checkInt(-4294967296);
+      expect(() => Int64.parseRadix('xyzzy', -1), throwsArgumentError);
+      expect(() => Int64.parseRadix('plugh', 10),
+          throwsA(new isInstanceOf<FormatException>()));
     });
 
     test("parseRadix", () {
       check(String s, int r, String x) {
         expect(Int64.parseRadix(s, r).toString(), x);
       }
       check('ghoul', 36, '27699213');
       check('ghoul', 35, '24769346');
       // Min and max value.
       check("-9223372036854775808", 10, "-9223372036854775808");
@@ skipping 71 matching lines @@
       expect(Int64.MAX_VALUE.toRadixString(10), "9223372036854775807");
       expect(Int64.MAX_VALUE.toRadixString(11), "1728002635214590697");
       expect(Int64.MAX_VALUE.toRadixString(12), "41a792678515120367");
       expect(Int64.MAX_VALUE.toRadixString(13), "10b269549075433c37");
       expect(Int64.MAX_VALUE.toRadixString(14), "4340724c6c71dc7a7");
       expect(Int64.MAX_VALUE.toRadixString(15), "160e2ad3246366807");
       expect(Int64.MAX_VALUE.toRadixString(16), "7fffffffffffffff");
     });
   });
 }