Adding embedder API function Dart_FinalizeLoading

Adding embedder API function Dart_FinalizeLoading

Embedder must call Dart_FinalizeLoading when all outstanding
load requests are satisfied, to complete the deferred loading
futures.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37423

[hausner, 2014-06-17 20:10:58]

As discussed offline, avoid calling Dart_Invoke()

[siva, 2014-06-17 20:43:19]

lgtm

https://codereview.chromium.org/341543004/diff/40001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/341543004/diff/40001/runtime/include/dart_api...
runtime/include/dart_api.h:2650: * finalizing classes and completing deferred
library futures.
*
* Requires there to be a current isolate.
*
* \return Success if all deferred library futures are completed.
*   Otherwise, returns an error.

https://codereview.chromium.org/341543004/diff/40001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/341543004/diff/40001/runtime/vm/dart_api_impl...
runtime/vm/dart_api_impl.cc:5113: CHECK_ISOLATE_SCOPE(isolate);
DARTSCOPE(isolate); so we get a new scope instead of using the outer scope.

https://codereview.chromium.org/341543004/diff/40001/runtime/vm/dart_api_impl...
runtime/vm/dart_api_impl.cc:5131: Api::NewHandle(isolate,
DartEntry::InvokeFunction(function, args));
_completeDeferredLoads does not seem to return any value on success so it would
be Object::null().

Usually these Api functions return Api::Success() or an Error.

Maybe
const Object& res = Object::Handle(isolate, ....);
if (res.IsError() || res.IsUnhandledException()) {
  return Api::NewHandle(isolate, res.raw());
}
return Api::Success();

[hausner, 2014-06-17 20:55:54]

Thank you.

https://codereview.chromium.org/341543004/diff/40001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/341543004/diff/40001/runtime/include/dart_api...
runtime/include/dart_api.h:2650: * finalizing classes and completing deferred
library futures.
On 2014/06/17 20:43:19, siva wrote:
> *
> * Requires there to be a current isolate.
> *
> * \return Success if all deferred library futures are completed.
> *   Otherwise, returns an error.

Done.

https://codereview.chromium.org/341543004/diff/40001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/341543004/diff/40001/runtime/vm/dart_api_impl...
runtime/vm/dart_api_impl.cc:5113: CHECK_ISOLATE_SCOPE(isolate);
On 2014/06/17 20:43:19, siva wrote:
> DARTSCOPE(isolate); so we get a new scope instead of using the outer scope.

Done.

https://codereview.chromium.org/341543004/diff/40001/runtime/vm/dart_api_impl...
runtime/vm/dart_api_impl.cc:5131: Api::NewHandle(isolate,
DartEntry::InvokeFunction(function, args));
On 2014/06/17 20:43:19, siva wrote:
> _completeDeferredLoads does not seem to return any value on success so it
would
> be Object::null().
> 
> Usually these Api functions return Api::Success() or an Error.
> 
> Maybe
> const Object& res = Object::Handle(isolate, ....);
> if (res.IsError() || res.IsUnhandledException()) {
>   return Api::NewHandle(isolate, res.raw());
> }
> return Api::Success();

Done.

[hausner, 2014-06-17 21:05:34]

Committed patchset #4 manually as r37423 (presubmit successful).