Adding embedder API function Dart_FinalizeLoading

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 
 #include "platform/assert.h"
 #include "vm/bigint_operations.h"
@@ skipping 5088 matching lines @@
   NoHeapGrowthControlScope no_growth_control;
 
   const Script& script = Script::Handle(
       isolate, Script::New(url_str, source_str, RawScript::kPatchTag));
   Dart_Handle result;
   CompileSource(isolate, lib, script, &result);
   return result;
 }
 
 
+// Finalizes classes and invokes Dart core library function that completes
+// futures of loadLibrary calls (deferred library loading).
+DART_EXPORT Dart_Handle Dart_FinalizeLoading() {
+  Isolate* isolate = Isolate::Current();
+  CHECK_ISOLATE_SCOPE(isolate);

[siva, 2014/06/17 20:43:19]

DARTSCOPE(isolate); so we get a new scope instead of using the outer scope.

[hausner, 2014/06/17 20:55:54]

Done.

+  CHECK_CALLBACK_STATE(isolate);
+
+  // Finalize all classes if needed.
+  Dart_Handle state = Api::CheckIsolateState(isolate);
+  if (::Dart_IsError(state)) {
+    return state;
+  }
+
+  const Library& corelib = Library::Handle(isolate, Library::CoreLibrary());
+  const String& function_name =
+      String::Handle(isolate, String::New("_completeDeferredLoads"));
+  const Function& function =
+      Function::Handle(isolate,
+                       corelib.LookupFunctionAllowPrivate(function_name));
+  ASSERT(!function.IsNull());
+  const Array& args = Array::empty_array();
+  Dart_Handle res =
+      Api::NewHandle(isolate, DartEntry::InvokeFunction(function, args));

[siva, 2014/06/17 20:43:19]

_completeDeferredLoads does not seem to return any value on success so it would
be Object::null().

Usually these Api functions return Api::Success() or an Error.

Maybe
const Object& res = Object::Handle(isolate, ....);
if (res.IsError() || res.IsUnhandledException()) {
  return Api::NewHandle(isolate, res.raw());
}
return Api::Success();

[hausner, 2014/06/17 20:55:54]

Done.

+  return res;
+}
+
+
 DART_EXPORT Dart_Handle Dart_SetNativeResolver(
     Dart_Handle library,
     Dart_NativeEntryResolver resolver,
     Dart_NativeEntrySymbol symbol) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   const Library& lib = Api::UnwrapLibraryHandle(isolate, library);
   if (lib.IsNull()) {
     RETURN_TYPE_ERROR(isolate, library, Library);
   }
@@ skipping 69 matching lines @@
 
 
 DART_EXPORT void Dart_RegisterRootServiceRequestCallback(
     const char* name,
     Dart_ServiceRequestCallback callback,
     void* user_data) {
   Service::RegisterRootEmbedderCallback(name, callback, user_data);
 }
 
 }  // namespace dart