Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 340443006: Add support for asynchronous event notification to the observatory. (Closed)

Created:
6 years, 6 months ago by turnidge
Modified:
6 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch
Visibility:
Public.

Description

Add support for asynchronous event notification to the observatory. Implement "isolate pause" notifications. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37841

Patch Set 1 #

Patch Set 2 : #

Total comments: 7

Patch Set 3 : code review edits #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8005 lines, -6637 lines) Patch
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 3 4 5 chunks +123 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 1 2 3 4 556 chunks +3574 lines, -3271 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 3 4 5 chunks +123 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 3 4 556 chunks +3574 lines, -3271 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_ref.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_summary.html View 1 2 3 4 2 chunks +14 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/nav_bar.html View 1 2 3 4 2 chunks +110 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/service_html.dart View 1 1 chunk +8 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/app/application.dart View 1 2 4 chunks +52 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_ref.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_summary.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html View 1 2 chunks +14 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/nav_bar.dart View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/nav_bar.html View 1 2 chunks +110 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/script_inset.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/service/object.dart View 1 2 3 4 8 chunks +66 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/server.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/debugger.h View 4 chunks +12 lines, -16 lines 0 comments Download
M runtime/vm/debugger.cc View 13 chunks +38 lines, -16 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/service.h View 3 chunks +27 lines, -5 lines 0 comments Download
M runtime/vm/service.cc View 1 2 3 4 5 chunks +54 lines, -6 lines 0 comments Download
M runtime/vm/service/client.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/service/constants.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/service/vmservice.dart View 1 3 chunks +67 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
turnidge
6 years, 6 months ago (2014-06-26 21:26:23 UTC) #1
turnidge
https://codereview.chromium.org/340443006/diff/20001/runtime/bin/vmservice/client/lib/src/app/application.dart File runtime/bin/vmservice/client/lib/src/app/application.dart (right): https://codereview.chromium.org/340443006/diff/20001/runtime/bin/vmservice/client/lib/src/app/application.dart#newcode257 runtime/bin/vmservice/client/lib/src/app/application.dart:257: vm = new WebSocketVM() { I recall that this ...
6 years, 6 months ago (2014-06-26 21:27:46 UTC) #2
Cutch
https://codereview.chromium.org/340443006/diff/20001/runtime/bin/vmservice/client/lib/src/app/application.dart File runtime/bin/vmservice/client/lib/src/app/application.dart (right): https://codereview.chromium.org/340443006/diff/20001/runtime/bin/vmservice/client/lib/src/app/application.dart#newcode257 runtime/bin/vmservice/client/lib/src/app/application.dart:257: vm = new WebSocketVM() { On 2014/06/26 21:27:46, turnidge ...
6 years, 5 months ago (2014-06-27 16:03:49 UTC) #3
turnidge
https://codereview.chromium.org/340443006/diff/20001/runtime/bin/vmservice/client/lib/src/app/application.dart File runtime/bin/vmservice/client/lib/src/app/application.dart (right): https://codereview.chromium.org/340443006/diff/20001/runtime/bin/vmservice/client/lib/src/app/application.dart#newcode257 runtime/bin/vmservice/client/lib/src/app/application.dart:257: vm = new WebSocketVM() { On 2014/06/27 16:03:49, Cutch ...
6 years, 5 months ago (2014-06-27 18:15:07 UTC) #4
Cutch
lgtm
6 years, 5 months ago (2014-06-27 20:21:42 UTC) #5
turnidge
6 years, 5 months ago (2014-06-30 22:46:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 manually as r37841 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698