runtime/bin/vmservice/client/lib/service_html.dart - Issue 340443006: Add support for asynchronous event notification to the observatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/service_html.dart

Issue 340443006: Add support for asynchronous event notification to the observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/nav_bar.html ('k') | runtime/bin/vmservice/client/lib/src/app/application.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/service_html.dart

diff --git a/runtime/bin/vmservice/client/lib/service_html.dart b/runtime/bin/vmservice/client/lib/service_html.dart

index d611bfec03a881321f2525d1eeb910bcea00e137..d235f4407ab060c496e609621642d02087175804 100644

--- a/runtime/bin/vmservice/client/lib/service_html.dart

+++ b/runtime/bin/vmservice/client/lib/service_html.dart

@@ -95,10 +95,16 @@ class WebSocketVM extends VM {

});

}

- void _handleMessage(MessageEvent event) {

- var map = JSON.decode(event.data);

+ void _handleMessage(MessageEvent message) {

+ var map = JSON.decode(message.data);

int seq = map['seq'];

var response = map['response'];

+ if (seq == null) {

+ // Messages without sequence numbers are asynchronous events

+ // from the vm.

+ postEventMessage(response);

+ return;

+ }

var completer = _pendingRequests.remove(seq);

if (completer == null) {

Logger.root.severe('Received unexpected message: ${map}');