Issue 339193003: Avoid calling anything related to signals on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339193003: Avoid calling anything related to signals on Windows (Closed)

Created:
6 years, 6 months ago by Cutch

Modified:
6 years, 6 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Avoid calling anything related to signals on Windows BUG= Committed: https://code.google.com/p/dart/source/detail?r=37402

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -5 lines)			Patch
	M	runtime/bin/vmservice/vmservice_io.dart	View		3 chunks	+7 lines, -5 lines	1 comment	Download
	M	runtime/bin/vmservice_impl.cc	View		1 chunk	+10 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Cutch

Committed patchset #1 manually as r37402 (presubmit successful).

6 years, 6 months ago (2014-06-17 15:58:10 UTC) #2

Anders Johnsen

6 years, 6 months ago (2014-06-18 07:24:11 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/339193003/diff/1/runtime/bin/vmservice/vmserv...
File runtime/bin/vmservice/vmservice_io.dart (right):

https://codereview.chromium.org/339193003/diff/1/runtime/bin/vmservice/vmserv...
runtime/bin/vmservice/vmservice_io.dart:50: if (_isWindows) {
Use Platform.isWindows.

https://codereview.chromium.org/339193003/diff/1/runtime/bin/vmservice_impl.cc
File runtime/bin/vmservice_impl.cc (right):

https://codereview.chromium.org/339193003/diff/1/runtime/bin/vmservice_impl.c...
runtime/bin/vmservice_impl.cc:145: // We cannot register for signals on windows.
Remove this.

Expand Messages | Collapse Messages