Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Unified Diff: runtime/bin/vmservice/vmservice_io.dart

Issue 339193003: Avoid calling anything related to signals on Windows (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/vmservice_impl.cc » ('j') | runtime/bin/vmservice_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/vmservice_io.dart
diff --git a/runtime/bin/vmservice/vmservice_io.dart b/runtime/bin/vmservice/vmservice_io.dart
index 3b3bc26a34d09e747aeb901128d1bed663897476..399b941dfd797dfb85fe335fe4a22fd7ed808fb5 100644
--- a/runtime/bin/vmservice/vmservice_io.dart
+++ b/runtime/bin/vmservice/vmservice_io.dart
@@ -20,6 +20,8 @@ String _ip;
// Should the HTTP server auto start?
bool _autoStart;
+bool _isWindows = false;
+
// HTTP servr.
Server server;
Future<Server> serverFuture;
@@ -45,6 +47,10 @@ void _onSignal(ProcessSignal signal) {
}
void registerSignalHandler() {
+ if (_isWindows) {
Anders Johnsen 2014/06/18 07:24:10 Use Platform.isWindows.
+ // Cannot register for signals on Windows.
+ return;
+ }
bool useSIGQUIT = true;
// Listen for SIGQUIT.
if (useSIGQUIT) {
@@ -68,9 +74,5 @@ main() {
server.startup();
}
- try {
- registerSignalHandler();
- } catch (_) {
- // Listening for signals will fail on Windows.
- }
+ registerSignalHandler();
}
« no previous file with comments | « no previous file | runtime/bin/vmservice_impl.cc » ('j') | runtime/bin/vmservice_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698