Issue 338353005: Fixes field access on MIPS for classes with many fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338353005: Fixes field access on MIPS for classes with many fields. (Closed)

Created:
6 years, 6 months ago by zra

Modified:
6 years, 6 months ago

Reviewers:
regis, Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Florian Schneider

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fixes field access on MIPS for classes with many fields. This mirrors yesterday's fix for ARM. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=37419

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15066 lines, -20 lines)			Patch
M	runtime/vm/assembler_mips.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_mips.cc	View	3 chunks	+38 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	4 chunks	+13 lines, -15 lines	0 comments	Download
M	tests/language/large_class_declaration_test.dart	View	2 chunks	+15004 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

zra

Committed patchset #1 manually as r37419 (presubmit successful).

6 years, 6 months ago (2014-06-17 20:44:29 UTC) #3

Florian Schneider

6 years, 6 months ago (2014-06-18 08:57:03 UTC) #4

Message was sent while issue was closed.

Lgtm.

I see - the test was not large enough to trigger the problem on MIPS.