Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1961)

Unified Diff: runtime/vm/intermediate_language_mips.cc

Issue 338353005: Fixes field access on MIPS for classes with many fields. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | tests/language/large_class_declaration_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_mips.cc
===================================================================
--- runtime/vm/intermediate_language_mips.cc (revision 37406)
+++ runtime/vm/intermediate_language_mips.cc (working copy)
@@ -1814,9 +1814,7 @@
temp2);
__ Bind(slow_path->exit_label());
__ mov(temp2, temp);
- __ StoreIntoObject(instance_reg,
- FieldAddress(instance_reg, offset_in_bytes_),
- temp2);
+ __ StoreIntoObjectOffset(instance_reg, offset_in_bytes_, temp2);
} else {
__ lw(temp, FieldAddress(instance_reg, offset_in_bytes_));
}
@@ -1877,9 +1875,7 @@
temp2);
__ Bind(slow_path->exit_label());
__ mov(temp2, temp);
- __ StoreIntoObject(instance_reg,
- FieldAddress(instance_reg, offset_in_bytes_),
- temp2);
+ __ StoreIntoObjectOffset(instance_reg, offset_in_bytes_, temp2);
__ Bind(&copy_double);
__ LoadDFromOffset(fpu_temp,
@@ -1895,20 +1891,21 @@
if (ShouldEmitStoreBarrier()) {
Register value_reg = locs()->in(1).reg();
- __ StoreIntoObject(instance_reg,
- FieldAddress(instance_reg, offset_in_bytes_),
- value_reg,
- CanValueBeSmi());
+ __ StoreIntoObjectOffset(instance_reg,
+ offset_in_bytes_,
+ value_reg,
+ CanValueBeSmi());
} else {
if (locs()->in(1).IsConstant()) {
- __ StoreIntoObjectNoBarrier(
+ __ StoreIntoObjectNoBarrierOffset(
instance_reg,
- FieldAddress(instance_reg, offset_in_bytes_),
+ offset_in_bytes_,
locs()->in(1).constant());
} else {
Register value_reg = locs()->in(1).reg();
- __ StoreIntoObjectNoBarrier(instance_reg,
- FieldAddress(instance_reg, offset_in_bytes_), value_reg);
+ __ StoreIntoObjectNoBarrierOffset(instance_reg,
+ offset_in_bytes_,
+ value_reg);
}
}
__ Bind(&skip_store);
@@ -2249,7 +2246,8 @@
__ Bind(&load_pointer);
}
- __ lw(result_reg, Address(instance_reg, offset_in_bytes() - kHeapObjectTag));
+ __ LoadFromOffset(
+ result_reg, instance_reg, offset_in_bytes() - kHeapObjectTag);
__ Bind(&done);
}
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | tests/language/large_class_declaration_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698