Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 337033003: Revert "New, more validating, parser for URI." and follow-up patches. (Closed)

Created:
6 years, 6 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Revert "New, more validating, parser for URI." and follow-up patches. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=37359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -565 lines) Patch
M pkg/json_rpc_2/test/server/parameters_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/bin/builtin.dart View 5 chunks +40 lines, -19 lines 0 comments Download
M sdk/lib/core/uri.dart View 17 chunks +143 lines, -308 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 chunk +3 lines, -27 lines 0 comments Download
M tests/co19/co19-co19.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/corelib/uri_scheme_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/corelib/uri_test.dart View 3 chunks +1 line, -197 lines 0 comments Download
M tests/standalone/io/http_client_exception_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
6 years, 6 months ago (2014-06-16 12:30:13 UTC) #1
Søren Gjesse
lgtm
6 years, 6 months ago (2014-06-16 12:30:41 UTC) #2
Lasse Reichstein Nielsen
6 years, 6 months ago (2014-06-16 12:32:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37359 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698