Revert "New, more validating, parser for URI." and follow-up patches.

runtime/bin/builtin.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library builtin;
 import 'dart:io';
 import 'dart:async';
 import 'dart:convert';
 // import 'root_library'; happens here from C Code
 
@@ skipping 148 matching lines @@
 var _entryPointScript;
 // The directory to look in to resolve "package:" scheme URIs.
 var _packageRoot;
 
 
 void _setWindows() {
   _isWindows = true;
 }
 
 
+_sanitizeWindowsPath(path) {
+  // For Windows we need to massage the paths a bit according to
+  // http://blogs.msdn.com/b/ie/archive/2006/12/06/file-uris-in-windows.aspx
+  //
+  // Convert
+  // C:\one\two\three
+  // to
+  // /C:/one/two/three
+
+  if (_isWindows == false) {
+    // Do nothing when not running Windows.
+    return path;
+  }
+
+  var fixedPath = "${path.replaceAll('\\', '/')}";
+
+  if ((path.length > 2) && (path[1] == ':')) {
+    // Path begins with a drive letter.
+    return '/$fixedPath';
+  }
+
+  return fixedPath;
+}
+
+
 _enforceTrailingSlash(uri) {
   // Ensure we have a trailing slash character.
   if (!uri.endsWith('/')) {
     return '$uri/';
   }
   return uri;
 }
 
 
 _extractDriveLetterPrefix(cwd) {
   if (!_isWindows) {
     return null;
   }
   if (cwd.length > 1 && cwd[1] == ':') {
     return '/${cwd[0]}:';
   }
   return null;
 }
 
 
 void _setWorkingDirectory(cwd) {
   _workingWindowsDrivePrefix = _extractDriveLetterPrefix(cwd);
-  _workingDirectoryUri = new Uri.file(cwd);
-  if (!_workingDirectoryUri.path.endsWith("/")) {
-    var directoryPath = _workingDirectoryUri.path + "/";
-    _workingDirectoryUri = _workingDirectoryUri.resolve(directoryPath);
-  }
-
+  cwd = _sanitizeWindowsPath(cwd);
+  cwd = _enforceTrailingSlash(cwd);
+  _workingDirectoryUri = new Uri(scheme: 'file', path: cwd);
   _logResolution('# Working Directory: $cwd');
 }
 
-Uri _uriFromPathOrUri(String location) {
-  if (location.startsWith('file:') ||
-      location.startsWith('http:') ||
-      location.startsWith('https:')) {
-    return Uri.parse(location);
-  }
-  return new Uri.file(location);
-}
 
 _setPackageRoot(String packageRoot) {
   packageRoot = _enforceTrailingSlash(packageRoot);
-  _packageRoot =
-      _workingDirectoryUri.resolveUri(_uriFromPathOrUri(packageRoot));
+  if (packageRoot.startsWith('file:') ||
+      packageRoot.startsWith('http:') ||
+      packageRoot.startsWith('https:')) {
+    _packageRoot = _workingDirectoryUri.resolve(packageRoot);
+  } else {
+    _packageRoot = _workingDirectoryUri.resolveUri(new Uri.file(packageRoot));
+  }
   _logResolution('# Package root: $packageRoot -> $_packageRoot');
 }
 
 
 String _resolveScriptUri(String scriptName) {
   if (_workingDirectoryUri == null) {
     throw 'No current working directory set.';
   }
-  var scriptUri = _uriFromPathOrUri(scriptName);
+  scriptName = _sanitizeWindowsPath(scriptName);
+
+  var scriptUri = Uri.parse(scriptName);
   if (scriptUri.scheme != '') {
     // Script has a scheme, assume that it is fully formed.
     _entryPointScript = scriptUri;
   } else {
     // Script does not have a scheme, assume that it is a path,
     // resolve it against the working directory.
     _entryPointScript = _workingDirectoryUri.resolve(scriptName);
   }
   _logResolution('# Resolved entry point to: $_entryPointScript');
   return _entryPointScript.toString();
@@ skipping 82 matching lines @@
   assert(_numOutstandingLoadRequests > 0);
   _numOutstandingLoadRequests--;
   _asyncLoadErrorCallback(uri, error);
 }
 
 
 // Asynchronously loads script data (source or snapshot) through
 // an http or file uri.
 _loadDataAsync(String uri) {
   uri = _resolveScriptUri(uri);
-  Uri sourceUri = _uriFromPathOrUri(uri);
+  Uri sourceUri = Uri.parse(uri);
   _numOutstandingLoadRequests++;
   _logResolution("_loadDataAsync($uri), "
                  "${_numOutstandingLoadRequests} requests outstanding");
   if (sourceUri.scheme == 'http') {
     _httpGet(sourceUri, (data) {
       _loadScript(uri, data);
     });
   } else {
     var sourceFile = new File(_filePathFromUri(uri));
     sourceFile.readAsBytes().then((data) {
@@ skipping 20 matching lines @@
                  "${_numOutstandingLoadRequests} requests remaining");
   if (_numOutstandingLoadRequests == 0) {
     _signalDoneLoading();
   }
 }
 
 
 // Asynchronously loads source code through an http or file uri.
 _loadSourceAsync(int tag, String uri, String libraryUri) {
   var filePath = _filePathFromUri(uri);
-  Uri sourceUri = new Uri.file(filePath);
+  Uri sourceUri = Uri.parse(filePath);
   _numOutstandingLoadRequests++;
   _logResolution("_loadLibrarySource($uri), "
                  "${_numOutstandingLoadRequests} requests outstanding");
   if (sourceUri.scheme == 'http') {
     _httpGet(sourceUri, (data) {
       var text = UTF8.decode(data);
       _loadLibrarySource(tag, uri, libraryUri, text);
     });
   } else {
     var sourceFile = new File(filePath);
@@ skipping 45 matching lines @@
   } else if (Platform.isWindows) {
     filename = '$name.dll';
   } else {
     _logResolution(
         'Native extensions not supported on ${Platform.operatingSystem}');
     throw 'Native extensions not supported on ${Platform.operatingSystem}';
   }
 
   return [path, filename, name];
 }