Issue 335793003: Enable OSR optimization for functions with try-catch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 335793003: Enable OSR optimization for functions with try-catch. (Closed)

Created:
6 years, 6 months ago by Florian Schneider

Modified:
6 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Enable OSR optimization for functions with try-catch. This is working. I added and extended tests to cover the different cases where OSR can occur (inside/outside try/catch) BUG=dartbug.com/16313,dartbug.com/17442 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37441

Patch Set 1 #

Patch Set 2 : improved tests #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -9 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View		1 chunk	+2 lines, -5 lines	0 comments	Download
M	tests/language/try_catch_optimized1_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/try_catch_optimized2_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/try_catch_optimized3_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A	tests/language/try_catch_osr_test.dart	View	1	1 chunk	+102 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

6 years, 6 months ago (2014-06-18 09:16:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r37441 (presubmit successful).

Expand Messages | Collapse Messages