Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 335793003: Enable OSR optimization for functions with try-catch. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: improved tests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/try_catch_optimized1_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 37390)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -3941,12 +3941,9 @@
ASSERT(!for_effect.is_open());
// When compiling for OSR, use a depth first search to prune instructions
- // unreachable from the OSR entry. Catch entries are not (yet) properly
- // recognized as reachable.
+ // unreachable from the OSR entry. Catch entries are always considered
+ // reachable, even if they become unreachable after OSR.
if (osr_id_ != Isolate::kNoDeoptId) {
- if (graph_entry_->SuccessorCount() > 1) {
- Bailout("try/catch when compiling for OSR");
- }
PruneUnreachable();
}
« no previous file with comments | « no previous file | tests/language/try_catch_optimized1_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698