Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2234)

Issue 334003003: Reduce warnings in polymer: (Closed)

Created:
6 years, 6 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 6 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reduce warnings in polymer: - don't report some warnings that come from parsing comments - don't report warnings when crawling the html in the linter (resulted in warnings being reported many many times) - remove incorrect warning for js onfoo events BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=37365

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -25 lines) Patch
M pkg/polymer/lib/src/build/common.dart View 2 chunks +18 lines, -8 lines 0 comments Download
M pkg/polymer/lib/src/build/linter.dart View 4 chunks +9 lines, -16 lines 2 comments Download
M pkg/polymer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
https://codereview.chromium.org/334003003/diff/20001/pkg/polymer/lib/src/build/linter.dart File pkg/polymer/lib/src/build/linter.dart (right): https://codereview.chromium.org/334003003/diff/20001/pkg/polymer/lib/src/build/linter.dart#newcode91 pkg/polymer/lib/src/build/linter.dart:91: logger.warning('couldn\'t find imported asset "${id.path}" in package' no reason ...
6 years, 6 months ago (2014-06-14 02:24:58 UTC) #1
Jennifer Messerly
Do we still get editor squiggles via build.dart? If so, LGTM
6 years, 6 months ago (2014-06-15 20:46:18 UTC) #2
Siggi Cherem (dart-lang)
On 2014/06/15 20:46:18, John Messerly wrote: > Do we still get editor squiggles via build.dart? ...
6 years, 6 months ago (2014-06-16 16:36:17 UTC) #3
Siggi Cherem (dart-lang)
6 years, 6 months ago (2014-06-16 17:00:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r37365 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698