Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: pkg/polymer/lib/src/build/common.dart

Issue 334003003: Reduce warnings in polymer: (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/polymer/lib/src/build/linter.dart » ('j') | pkg/polymer/lib/src/build/linter.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/lib/src/build/common.dart
diff --git a/pkg/polymer/lib/src/build/common.dart b/pkg/polymer/lib/src/build/common.dart
index 77e8db7272199ed918a6b35dfce60ad6867b5bd6..740c187931473e08cc415460adebaa48c3ab29ad 100644
--- a/pkg/polymer/lib/src/build/common.dart
+++ b/pkg/polymer/lib/src/build/common.dart
@@ -18,20 +18,28 @@ import 'package:path/path.dart' as path;
import 'package:observe/transformer.dart' show ObservableTransformer;
import 'package:source_maps/span.dart' show Span;
+const _ignoredErrors = const [
+ 'unexpected-dash-after-double-dash-in-comment',
+ 'unexpected-char-in-comment',
+];
+
/// Parses an HTML file [contents] and returns a DOM-like tree. Adds emitted
/// error/warning to [logger].
Document _parseHtml(String contents, String sourcePath, TransformLogger logger,
- {bool checkDocType: true}) {
+ {bool checkDocType: true, bool showWarnings: true}) {
// TODO(jmesserly): make HTTP encoding configurable
- var parser = new HtmlParser(contents, encoding: 'utf8', generateSpans: true,
- sourceUrl: sourcePath);
+ var parser = new HtmlParser(contents, encoding: 'utf8',
+ generateSpans: showWarnings, sourceUrl: sourcePath);
var document = parser.parse();
// Note: errors aren't fatal in HTML (unless strict mode is on).
// So just print them as warnings.
- for (var e in parser.errors) {
- if (checkDocType || e.errorCode != 'expected-doctype-but-got-start-tag') {
- logger.warning(e.message, span: e.span);
+ if (showWarnings) {
+ for (var e in parser.errors) {
+ if (_ignoredErrors.contains(e.errorCode)) continue;
+ if (checkDocType || e.errorCode != 'expected-doctype-but-got-start-tag') {
+ logger.warning(e.message, span: e.span);
+ }
}
}
return document;
@@ -99,13 +107,15 @@ abstract class PolymerTransformer {
});
}
- Future<Document> readAsHtml(AssetId id, Transform transform) {
+ Future<Document> readAsHtml(AssetId id, Transform transform,
+ {bool showWarnings: true}) {
var primaryId = transform.primaryInput.id;
bool samePackage = id.package == primaryId.package;
var url = spanUrlFor(id, transform);
return transform.readInputAsString(id).then((content) {
return _parseHtml(content, url, transform.logger,
- checkDocType: samePackage && options.isHtmlEntryPoint(id));
+ checkDocType: samePackage && options.isHtmlEntryPoint(id),
+ showWarnings: showWarnings);
});
}
« no previous file with comments | « no previous file | pkg/polymer/lib/src/build/linter.dart » ('j') | pkg/polymer/lib/src/build/linter.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698