Make listToMap and mapMap use named parameters.

Make listToMap and mapMap use named parameters.

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37373

[Bob Nystrom, 2014-06-13 17:18:21]

Two suggestions then LGTM.

https://codereview.chromium.org/331663006/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart (right):

https://codereview.chromium.org/331663006/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart:218: var
packageTransformers = listToMap(graph.packages.values,
Can you just use new Map.fromIterable() here?

https://codereview.chromium.org/331663006/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/utils.dart (right):

https://codereview.chromium.org/331663006/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/utils.dart:315: value: (mapKey) => value(mapKey,
map[mapKey]));
Iterating the keys and then using them to turn around and look up the value
isn't very efficient. How about:

var result = {};
map.forEach((k, v) {
  result.add(key(k, v), value(k, v));
});

[nweiz, 2014-06-16 19:44:47]

https://codereview.chromium.org/331663006/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart (right):

https://codereview.chromium.org/331663006/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart:218: var
packageTransformers = listToMap(graph.packages.values,
On 2014/06/13 17:18:21, Bob Nystrom wrote:
> Can you just use new Map.fromIterable() here?

Done. I just got rid of listToMap entirely, and renamed listToMapAsync to
mapFromIterableAsync.

https://codereview.chromium.org/331663006/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/utils.dart (right):

https://codereview.chromium.org/331663006/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/utils.dart:315: value: (mapKey) => value(mapKey,
map[mapKey]));
On 2014/06/13 17:18:21, Bob Nystrom wrote:
> Iterating the keys and then using them to turn around and look up the value
> isn't very efficient. How about:
> 
> var result = {};
> map.forEach((k, v) {
>   result.add(key(k, v), value(k, v));
> });

Done.

[nweiz, 2014-06-16 19:45:25]

Committed patchset #2 manually as r37373 (presubmit successful).