Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart

Issue 331663006: Make listToMap and mapMap use named parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart
diff --git a/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart b/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart
index 6393aec51bd0d5295d670e8a61aa2779aa84ebb1..f8827f2ce79fe57b0101572ab6755f890cff4e93 100644
--- a/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart
+++ b/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart
@@ -194,8 +194,8 @@ ApplicationException _cycleError(PackageGraph graph, String dependee,
String depender) {
assert(_transformerDeps(graph, depender).contains(dependee));
- var simpleGraph = mapMapValues(graph.packages,
- (_, package) => package.dependencies.map((dep) => dep.name).toList());
+ var simpleGraph = mapMap(graph.packages, value: (_, package) =>
+ package.dependencies.map((dep) => dep.name).toList());
var path = shortestPath(simpleGraph, dependee, depender);
path.add(dependee);
return new ApplicationException("Transformer cycle detected:\n" +
@@ -215,8 +215,9 @@ ApplicationException _cycleError(PackageGraph graph, String dependee,
/// all transformers exposed by that package and used by other packages.
Map<String, Set<TransformerId>> _computePackageTransformers(
PackageGraph graph) {
- var packageTransformers = listToMap(graph.packages.values,
- (package) => package.name, (_) => new Set<TransformerId>());
+ var packageTransformers = new Map.fromIterable(graph.packages.values,
+ key: (package) => package.name,
+ value: (_) => new Set<TransformerId>());
for (var package in graph.packages.values) {
for (var phase in package.pubspec.transformers) {
for (var id in phase) {
« no previous file with comments | « no previous file | sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698