Issue 331323002: Show pid on Observatory VM page

Issue 331323002: Show pid on Observatory VM page (Closed)

Created:
6 years, 6 months ago by Cutch

Modified:
6 years, 6 months ago

Reviewers:
koda

CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Show pid on Observatory VM page BUG= R=koda@google.com Committed: https://code.google.com/p/dart/source/detail?r=37415

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
M	runtime/bin/vmservice/client/lib/src/elements/vm_view.html	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/service/object.dart	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/service.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

koda

https://codereview.chromium.org/331323002/diff/1/runtime/vm/service.cc File runtime/vm/service.cc (right): https://codereview.chromium.org/331323002/diff/1/runtime/vm/service.cc#newcode1942 runtime/vm/service.cc:1942: jsobj.AddPropertyF("pid", "%" Pd "", OS::ProcessId()); Why not use AddProperty(const ...

6 years, 6 months ago (2014-06-16 23:54:46 UTC) #2

Cutch

6 years, 6 months ago (2014-06-17 14:49:16 UTC) #3

Cutch

6 years, 6 months ago (2014-06-17 20:16:06 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r37415 (presubmit successful).

Expand Messages | Collapse Messages