Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 329793002: Add missing javascript integer overflow check on 64-bit platforms. (Closed)

Created:
6 years, 6 months ago by regis
Modified:
6 years, 6 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add missing javascript integer overflow check on 64-bit platforms. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37244

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
6 years, 6 months ago (2014-06-11 18:35:10 UTC) #1
srdjan
lgtm
6 years, 6 months ago (2014-06-11 20:46:22 UTC) #2
regis
6 years, 6 months ago (2014-06-11 20:46:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r37244 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698