Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 329793002: Add missing javascript integer overflow check on 64-bit platforms. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 10 matching lines...) Expand all
21 #include "vm/stub_code.h" 21 #include "vm/stub_code.h"
22 #include "vm/symbols.h" 22 #include "vm/symbols.h"
23 23
24 namespace dart { 24 namespace dart {
25 25
26 DEFINE_FLAG(bool, trap_on_deoptimization, false, "Trap on deoptimization."); 26 DEFINE_FLAG(bool, trap_on_deoptimization, false, "Trap on deoptimization.");
27 DEFINE_FLAG(bool, unbox_mints, true, "Optimize 64-bit integer arithmetic."); 27 DEFINE_FLAG(bool, unbox_mints, true, "Optimize 64-bit integer arithmetic.");
28 DECLARE_FLAG(int, optimization_counter_threshold); 28 DECLARE_FLAG(int, optimization_counter_threshold);
29 DECLARE_FLAG(int, reoptimization_counter_threshold); 29 DECLARE_FLAG(int, reoptimization_counter_threshold);
30 DECLARE_FLAG(bool, enable_type_checks); 30 DECLARE_FLAG(bool, enable_type_checks);
31 DECLARE_FLAG(bool, throw_on_javascript_int_overflow);
32 DECLARE_FLAG(bool, enable_simd_inline); 31 DECLARE_FLAG(bool, enable_simd_inline);
33 32
34 33
35 FlowGraphCompiler::~FlowGraphCompiler() { 34 FlowGraphCompiler::~FlowGraphCompiler() {
36 // BlockInfos are zone-allocated, so their destructors are not called. 35 // BlockInfos are zone-allocated, so their destructors are not called.
37 // Verify the labels explicitly here. 36 // Verify the labels explicitly here.
38 for (int i = 0; i < block_info_.length(); ++i) { 37 for (int i = 0; i < block_info_.length(); ++i) {
39 ASSERT(!block_info_[i]->jump_label()->IsLinked()); 38 ASSERT(!block_info_[i]->jump_label()->IsLinked());
40 ASSERT(!block_info_[i]->jump_label()->HasNear()); 39 ASSERT(!block_info_[i]->jump_label()->HasNear());
41 } 40 }
(...skipping 1698 matching lines...) Expand 10 before | Expand all | Expand 10 after
1740 __ movups(reg, Address(ESP, 0)); 1739 __ movups(reg, Address(ESP, 0));
1741 __ addl(ESP, Immediate(kFpuRegisterSize)); 1740 __ addl(ESP, Immediate(kFpuRegisterSize));
1742 } 1741 }
1743 1742
1744 1743
1745 #undef __ 1744 #undef __
1746 1745
1747 } // namespace dart 1746 } // namespace dart
1748 1747
1749 #endif // defined TARGET_ARCH_IA32 1748 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698