Issue 327803003: Provide the isolate with a trace buffer, but do not allocate one by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 327803003: Provide the isolate with a trace buffer, but do not allocate one by default. (Closed)

Created:
6 years, 6 months ago by regis

Modified:
6 years, 6 months ago

Reviewers:
Cutch, john

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Provide the isolate with a trace buffer, but do not allocate one by default. This will be used to report warnings to the observatory. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37184

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -16 lines)			Patch
M	runtime/vm/isolate.h	View		3 chunks	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/isolate.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/trace_buffer.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/trace_buffer.cc	View		2 chunks	+12 lines, -5 lines	0 comments	Download
M	runtime/vm/trace_buffer_test.cc	View	1	4 chunks	+16 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

regis

6 years, 6 months ago (2014-06-10 17:06:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r37184 (presubmit successful).