runtime/vm/trace_buffer.h - Issue 327803003: Provide the isolate with a trace buffer, but do not allocate one by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/trace_buffer.h

Issue 327803003: Provide the isolate with a trace buffer, but do not allocate one by default. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/trace_buffer.h

===================================================================

--- runtime/vm/trace_buffer.h (revision 37183)

+++ runtime/vm/trace_buffer.h (working copy)

@@ -25,7 +25,8 @@

public:

static const intptr_t kDefaultCapacity = 1024;

- explicit TraceBuffer(intptr_t capacity = kDefaultCapacity);

+ static void Init(Isolate* isolate, intptr_t capacity = kDefaultCapacity);

~TraceBuffer();

void Clear();

@@ -39,11 +40,12 @@

void PrintToJSONStream(JSONStream* stream) const;

private:

- void Init();

+ TraceBuffer(Isolate* isolate, intptr_t capacity);

void Cleanup();

void Fill(TraceBufferEntry* entry, int64_t micros, char* msg);

void AppendTrace(int64_t micros, char* message);

+ Isolate* isolate_;

TraceBufferEntry* ring_;

const intptr_t ring_capacity_;

intptr_t ring_cursor_;

« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/trace_buffer.cc » ('j') | no next file with comments »