Make it really green :) --- ensure that we register Dart type after the polyfill

Make it really green :) --- ensure that we register Dart type after the polyfill
is ready. This helps make the test deterministic.
R=jmesserly@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37149

[Siggi Cherem (dart-lang), 2014-06-09 23:56:01]

Committed patchset #1 manually as r37149 (presubmit successful).

[Jennifer Messerly, 2014-06-10 00:04:17]

https://codereview.chromium.org/325973002/diff/1/pkg/web_components/test/inte...
File pkg/web_components/test/interop2_test.dart (right):

https://codereview.chromium.org/325973002/diff/1/pkg/web_components/test/inte...
pkg/web_components/test/interop2_test.dart:21: setUp(() =>
customElementsReady.then((_) {
won't this try and register elements repeatedly at each test?

perhaps:

final globalSetup = customElementsReady.then((_) {
  registerDartType('x-a', XAWrapper);
  registerDartType('x-b', XBWrapper, extendsTag: 'div');
  registerDartType('x-c', XCWrapper);
});

setUp(() => globalSetup);

https://codereview.chromium.org/325973002/diff/1/pkg/web_components/test/inte...
File pkg/web_components/test/interop_test.dart (right):

https://codereview.chromium.org/325973002/diff/1/pkg/web_components/test/inte...
pkg/web_components/test/interop_test.dart:17: setUp(() =>
customElementsReady.then((_) {
same here

[Siggi Cherem (dart-lang), 2014-06-10 00:12:14]

good catch!

https://codereview.chromium.org/325973002/diff/1/pkg/web_components/test/inte...
File pkg/web_components/test/interop2_test.dart (right):

https://codereview.chromium.org/325973002/diff/1/pkg/web_components/test/inte...
pkg/web_components/test/interop2_test.dart:21: setUp(() =>
customElementsReady.then((_) {
On 2014/06/10 00:04:17, John Messerly wrote:
> won't this try and register elements repeatedly at each test?
> 
> perhaps:
> 
> final globalSetup = customElementsReady.then((_) {
>   registerDartType('x-a', XAWrapper);
>   registerDartType('x-b', XBWrapper, extendsTag: 'div');
>   registerDartType('x-c', XCWrapper);
> });
> 
> setUp(() => globalSetup);

Yep, you are right. I'll send a fix shortly. I think this didn't fail in the
tests because we drop the subsequent register calls (we do report a
console.error in that case though).

https://codereview.chromium.org/325973002/diff/1/pkg/web_components/test/inte...
File pkg/web_components/test/interop_test.dart (right):

https://codereview.chromium.org/325973002/diff/1/pkg/web_components/test/inte...
pkg/web_components/test/interop_test.dart:17: setUp(() =>
customElementsReady.then((_) {
On 2014/06/10 00:04:17, John Messerly wrote:
> same here

Done.

[Jennifer Messerly, 2014-06-10 00:15:14]

sounds good! lgtm w/ follow up :)