Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: pkg/web_components/test/interop2_test.dart

Issue 325973002: Make it really green :) --- ensure that we register Dart type after the polyfill (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/web_components/test/interop_test.dart » ('j') | pkg/web_components/test/interop_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/web_components/test/interop2_test.dart
diff --git a/pkg/web_components/test/interop2_test.dart b/pkg/web_components/test/interop2_test.dart
index e84e8ceb171a8dc284ed27fdd576ce6529c91e59..88cc25cd6473f430cb08bd91096ad5d3422475e9 100644
--- a/pkg/web_components/test/interop2_test.dart
+++ b/pkg/web_components/test/interop2_test.dart
@@ -18,11 +18,11 @@ import 'package:web_components/polyfill.dart';
main() {
useHtmlConfiguration();
- registerDartType('x-a', XAWrapper);
- registerDartType('x-b', XBWrapper, extendsTag: 'div');
- registerDartType('x-c', XCWrapper);
-
- setUp(() => customElementsReady);
+ setUp(() => customElementsReady.then((_) {
Jennifer Messerly 2014/06/10 00:04:17 won't this try and register elements repeatedly at
Siggi Cherem (dart-lang) 2014/06/10 00:12:13 Yep, you are right. I'll send a fix shortly. I thi
+ registerDartType('x-a', XAWrapper);
+ registerDartType('x-b', XBWrapper, extendsTag: 'div');
+ registerDartType('x-c', XCWrapper);
+ }));
test('interop is supported', () {
expect(isSupported, isTrue);
« no previous file with comments | « no previous file | pkg/web_components/test/interop_test.dart » ('j') | pkg/web_components/test/interop_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698