Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 321903002: Hoist creation of Smi handles and String handles out of the loop in (Closed)

Created:
6 years, 6 months ago by siva
Modified:
6 years, 6 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Hoist creation of Smi handles and String handles out of the loop in Script::GenerateLineNumberArray() R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=37200

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M runtime/vm/object.cc View 3 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
6 years, 6 months ago (2014-06-09 23:30:59 UTC) #1
hausner
LGTM!
6 years, 6 months ago (2014-06-10 02:38:38 UTC) #2
siva
6 years, 6 months ago (2014-06-10 20:49:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r37200 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698