Hoist creation of Smi handles and String handles out of the loop in

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 7797 matching lines @@
 }
 
 
 RawString* Script::GenerateSource() const {
   const TokenStream& token_stream = TokenStream::Handle(tokens());
   return token_stream.GenerateSource();
 }
 
 
 RawGrowableObjectArray* Script::GenerateLineNumberArray() const {
+  Isolate* isolate = Isolate::Current();
   const GrowableObjectArray& info =
-      GrowableObjectArray::Handle(GrowableObjectArray::New());
-  const String& source = String::Handle(Source());
+      GrowableObjectArray::Handle(isolate, GrowableObjectArray::New());
+  const String& source = String::Handle(isolate, Source());
   const String& key = Symbols::Empty();
-  const Object& line_separator = Object::Handle();
-  const TokenStream& tkns = TokenStream::Handle(tokens());
+  const Object& line_separator = Object::Handle(isolate);
+  const TokenStream& tkns = TokenStream::Handle(isolate, tokens());
+  Smi& value = Smi::Handle(isolate);
+  String& tokenValue = String::Handle(isolate);
   ASSERT(!tkns.IsNull());
   TokenStream::Iterator tkit(tkns, 0, TokenStream::Iterator::kAllTokens);
   int current_line = -1;
   Scanner s(source, key);
   s.Scan();
   bool skippedNewline = false;
   while (tkit.CurrentTokenKind() != Token::kEOS) {
     if (tkit.CurrentTokenKind() == Token::kNEWLINE) {
       // Skip newlines from the token stream.
       skippedNewline = true;
@@ skipping 17 matching lines @@
       // 13    string('') interpol_var(foo) string('\n')
       // 14
       //
       // In order to keep the token iterator and the scanner in sync,
       // we need to skip the extra empty string before the
       // interpolation.
       if (skippedNewline &&
           (s.current_token().kind == Token::kINTERPOL_VAR ||
            s.current_token().kind == Token::kINTERPOL_START) &&
           tkit.CurrentTokenKind() == Token::kSTRING) {
-        const String& tokenValue = String::Handle(tkit.CurrentLiteral());
+        tokenValue = tkit.CurrentLiteral();
         if (tokenValue.Length() == 0) {
           tkit.Advance();
         }
       }
     }
     skippedNewline = false;
     ASSERT(s.current_token().kind == tkit.CurrentTokenKind());
     int token_line = s.current_token().position.line;
     if (token_line != current_line) {
       // emit line
       info.Add(line_separator);
-      info.Add(Smi::Handle(Smi::New(token_line + line_offset())));
+      value = Smi::New(token_line + line_offset());
+      info.Add(value);
       current_line = token_line;
     }
     // TODO(hausner): Could optimize here by not reporting tokens
     // that will never be a location used by the debugger, e.g.
     // braces, semicolons, most keywords etc.
-    info.Add(Smi::Handle(Smi::New(tkit.CurrentPosition())));
+    value = Smi::New(tkit.CurrentPosition());
+    info.Add(value);
     int column = s.current_token().position.column;
     // On the first line of the script we must add the column offset.
     if (token_line == 1) {
       column += col_offset();
     }
-    info.Add(Smi::Handle(Smi::New(column)));
+    value = Smi::New(column);
+    info.Add(value);
     tkit.Advance();
     s.Scan();
   }
   return info.raw();
 }
 
 
 const char* Script::GetKindAsCString() const {
   switch (kind()) {
     case RawScript::kScriptTag:
@@ skipping 11112 matching lines @@
   return tag_label.ToCString();
 }
 
 
 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
   Instance::PrintJSONImpl(stream, ref);
 }
 
 
 }  // namespace dart