Issue 32113003: Use os.remove() instead of shutil.rmtree() since the latter actually does follow pseudo-symlinks on…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 32113003: Use os.remove() instead of shutil.rmtree() since the latter actually does follow pseudo-symlinks on… (Closed)

Created:
7 years, 2 months ago by kustermann

Modified:
7 years, 2 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use os.remove() instead of shutil.rmtree() since the latter actually does follow pseudo-symlinks on windows TBR=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=29063

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	dart/tools/make_links.py	View		1 chunk	+6 lines, -5 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kustermann

https://codereview.chromium.org/32113003/diff/1/dart/tools/make_links.py File dart/tools/make_links.py (right): https://codereview.chromium.org/32113003/diff/1/dart/tools/make_links.py#newcode70 dart/tools/make_links.py:70: os.remove(os.path.join(target, link)) If os.remove() raises on these pseudo-symlinks, I'll ...

7 years, 2 months ago (2013-10-23 08:10:29 UTC) #1

kustermann

7 years, 2 months ago (2013-10-23 08:11:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29063 (presubmit successful).

Expand Messages | Collapse Messages